Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5da444aa authored by Akinobu Mita's avatar Akinobu Mita Committed by David S. Miller
Browse files

sparc: fix format string argument for prom_printf() 



prom_printf() takes printf style arguments.  Specifing GCC's format
attribute reveals that there are several wrong usages of prom_printf().

This fixes those wrong format strings and arguments, and also leaves
format attributes in order to detect similar mistakes at compile time.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 97da37b3

arch/sparc/include/asm/oplib_32.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -94,7 +94,7 @@ extern int prom_getprev(void); 
extern void prom_console_write_buf(const char *buf, int len);

extern void prom_console_write_buf(const char *buf, int len);





/* Prom's internal routines, don't use in kernel/boot code. */

/* Prom's internal routines, don't use in kernel/boot code. */

extern void prom_printf(const char *fmt, ...);

extern __printf(1, 2) void prom_printf(const char *fmt, ...);

extern void prom_write(const char *buf, unsigned int len);

extern void prom_write(const char *buf, unsigned int len);





/* Multiprocessor operations... */

/* Multiprocessor operations... */

arch/sparc/include/asm/oplib_64.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -98,7 +98,7 @@ extern unsigned char prom_get_idprom(char *idp_buffer, int idpbuf_size); 
extern void prom_console_write_buf(const char *buf, int len);

extern void prom_console_write_buf(const char *buf, int len);





/* Prom's internal routines, don't use in kernel/boot code. */

/* Prom's internal routines, don't use in kernel/boot code. */

extern void prom_printf(const char *fmt, ...);

extern __printf(1, 2) void prom_printf(const char *fmt, ...);

extern void prom_write(const char *buf, unsigned int len);

extern void prom_write(const char *buf, unsigned int len);





/* Multiprocessor operations... */

/* Multiprocessor operations... */

arch/sparc/kernel/hvapi.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -194,7 +194,7 @@ void __init sun4v_hvapi_init(void) 




bad:

bad:

	prom_printf("HVAPI: Cannot register API group "

	prom_printf("HVAPI: Cannot register API group "

		    "%lx with major(%u) minor(%u)\n",

		    "%lx with major(%lu) minor(%lu)\n",

		    group, major, minor);

		    group, major, minor);

	prom_halt();

	prom_halt();

}
 
}

arch/sparc/kernel/prom_64.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -37,7 +37,7 @@ void * __init prom_early_alloc(unsigned long size) 
	void *ret;

	void *ret;





	if (!paddr) {

	if (!paddr) {

		prom_printf("prom_early_alloc(%lu) failed\n");

		prom_printf("prom_early_alloc(%lu) failed\n", size);

		prom_halt();

		prom_halt();

	}

	}

arch/sparc/kernel/traps_64.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -850,7 +850,7 @@ void __init cheetah_ecache_flush_init(void) 
	ecache_flush_physbase = find_ecache_flush_span(ecache_flush_size);

	ecache_flush_physbase = find_ecache_flush_span(ecache_flush_size);





	if (ecache_flush_physbase == ~0UL) {

	if (ecache_flush_physbase == ~0UL) {

		prom_printf("cheetah_ecache_flush_init: Cannot find %d byte "

		prom_printf("cheetah_ecache_flush_init: Cannot find %ld byte "

			    "contiguous physical memory.\n",

			    "contiguous physical memory.\n",

			    ecache_flush_size);

			    ecache_flush_size);

		prom_halt();

		prom_halt();