Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d5d9827 authored by Xu Yang's avatar Xu Yang Committed by Greg Kroah-Hartman
Browse files

usb: phy: mxs: remove CONFIG_USB_OTG condition for mxs_phy_is_otg_host() 



commit ff2b89de471da942a4d853443688113a44fd35ed upstream.

When CONFIG_USB_OTG is not set, mxs_phy_is_otg_host() will always return
false. This behaviour is wrong. Since phy.last_event will always be set
for either host or device mode. Therefore, CONFIG_USB_OTG condition
can be removed.

Fixes: 5eda42aebb76 ("usb: phy: mxs: fix getting wrong state with mxs_phy_is_otg_host()")
cc:  <stable@vger.kernel.org>
Acked-by: default avatarPeter Chen <peter.chen@kernel.org>
Signed-off-by: default avatarXu Yang <xu.yang_2@nxp.com>
Link: https://lore.kernel.org/r/20231228110753.1755756-3-xu.yang_2@nxp.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 29032c8e

drivers/usb/phy/phy-mxs-usb.c

+1 −2
Original line number Diff line number Diff line
@@ -388,8 +388,7 @@ static void __mxs_phy_disconnect_line(struct mxs_phy *mxs_phy, bool disconnect) 


static bool mxs_phy_is_otg_host(struct mxs_phy *mxs_phy)

{

	return IS_ENABLED(CONFIG_USB_OTG) &&

		mxs_phy->phy.last_event == USB_EVENT_ID;

	return mxs_phy->phy.last_event == USB_EVENT_ID;

}



static void mxs_phy_disconnect_line(struct mxs_phy *mxs_phy, bool on)