Commit 5d5ceb8b authored Aug 06, 2009 by Roel Kluin Committed by David S. Miller Aug 09, 2009

irda: fix read buffer overflow



io[i] is read before the bounds check on i, order should be reversed.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cb2f33e9

drivers/net/irda/w83977af_ir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -115,7 +115,7 @@ static int __init w83977af_init(void)

		IRDA_DEBUG(0, "%s()\n", __func__ );

		for (i=0; (io[i] < 2000) && (i < ARRAY_SIZE(dev_self)); i++) {
		for (i=0; i < ARRAY_SIZE(dev_self) && io[i] < 2000; i++) {
		if (w83977af_open(i, io[i], irq[i], dma[i]) == 0)
		return 0;
		}