Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d4acfc1 authored by Markus Elfring's avatar Markus Elfring Committed by Marcel Holtmann
Browse files

Bluetooth: Delete error messages for failed memory allocations in two functions 

Omit two extra messages for memory allocation failures in these functions.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf


Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 5bd425aa

net/bluetooth/ecdh_helper.c

+3 −8
Original line number Diff line number Diff line
@@ -89,11 +89,9 @@ bool compute_ecdh_secret(const u8 public_key[64], const u8 private_key[32], 
	p.curve_id = ECC_CURVE_NIST_P256;

	buf_len = crypto_ecdh_key_len(&p);

	buf = kmalloc(buf_len, GFP_KERNEL);

	if (!buf) {

		pr_err("alg: kpp: Failed to allocate %d bytes for buf\n",

		       buf_len);

	if (!buf)

		goto free_req;

	}



	crypto_ecdh_encode_key(buf, buf_len, &p);



	/* Set A private Key */
@@ -170,11 +168,8 @@ bool generate_ecdh_keys(u8 public_key[64], u8 private_key[32]) 
	p.key_size = 32;

	buf_len = crypto_ecdh_key_len(&p);

	buf = kmalloc(buf_len, GFP_KERNEL);

	if (!buf) {

		pr_err("alg: kpp: Failed to allocate %d bytes for buf\n",

		       buf_len);

	if (!buf)

		goto free_req;

	}



	do {

		if (tries++ >= max_tries)