Commit 5d44670f authored May 05, 2011 by Marcus Meissner Committed by Joel Becker May 13, 2011

ocfs2: Initialize data_ac (might be used uninitialized)



CLANG found that there is a path that has data_ac uninitialized,
this place
	2917	/* This gets us the dx_root */
	2918	ret = ocfs2_reserve_new_metadata_blocks(osb, 1, &meta_ac);
	2919	if (ret) {

	3
		Taking true branch
	2920	mlog_errno(ret);
	2921	goto out;

	4
		Control jumps to line 3168
	2922	}

Goes to the out: label without data_ac being initialized.

Ciao, Marcus

Signed-Off-By: Marcus Meissner <meissner@suse.de>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Joel Becker <jlbec@evilplan.org>

parent 446cc634

fs/ocfs2/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2868,7 +2868,7 @@ static int ocfs2_expand_inline_dir(struct inode dir, struct buffer_head di_bh,
		bytes = blocks_wanted << sb->s_blocksize_bits;
		struct ocfs2_super *osb = OCFS2_SB(dir->i_sb);
		struct ocfs2_inode_info *oi = OCFS2_I(dir);
		struct ocfs2_alloc_context *data_ac;
		struct ocfs2_alloc_context *data_ac = NULL;
		struct ocfs2_alloc_context *meta_ac = NULL;
		struct buffer_head *dirdata_bh = NULL;
		struct buffer_head *dx_root_bh = NULL;