Commit 5d042fbd authored Aug 22, 2013 by Alex Williamson

vfio: Add O_CLOEXEC flag to vfio device fd



Add the default O_CLOEXEC flag for device file descriptors.  This is
generally considered a safer option as it allows the user a race free
option to decide whether file descriptors are inherited across exec,
with the default avoiding file descriptor leaks.

Reported-by: Yann Droneaud <ydroneaud@opteya.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

parent a5d55070

drivers/vfio/vfio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1109,7 +1109,7 @@ static int vfio_group_get_device_fd(struct vfio_group group, char buf)
		* We can't use anon_inode_getfd() because we need to modify
		* the f_mode flags directly to allow more than just ioctls
		*/
		ret = get_unused_fd_flags(0);
		ret = get_unused_fd_flags(O_CLOEXEC);
		if (ret < 0) {
		device->ops->release(device->device_data);
		break;