Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ccad5a6 authored by Jordan Crouse's avatar Jordan Crouse Committed by Hemant Kumar
Browse files

mhi: Fix compile errors 



module_init() was incorrectly used instead of module_exit(). Fix
the macro and the exit function for the correct prototype. Slightly
adjust a function callback to match the header prototype and add a
missing variable.

Fixes: 689af8a2e0a ("mhi: add snapshot for MHI driver stack").

Change-Id: Ic0dedbad55f535efd0d77b9bb3ff0ea1e25d6f3a
Signed-off-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: default avatarHemant Kumar <hemantk@codeaurora.org>
parent 187d2284

drivers/bus/mhi/devices/mhi_netdev.c

+4 −4
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/* Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.*/

/* Copyright (c) 2018-2020, The Linux Foundation. All rights reserved.*/



#include <linux/module.h>

#include <linux/kernel.h>
@@ -948,7 +948,7 @@ static void mhi_netdev_remove(struct mhi_device *mhi_dev) 
		debugfs_remove_recursive(mhi_netdev->dentry);

}



static int mhi_netdev_match(struct device *dev, void *data)

static int mhi_netdev_match(struct device *dev, const void *data)

{

	/* if phandle dt == device dt, we found a match */

	return (dev->of_node == data);
@@ -1131,13 +1131,13 @@ static int __init mhi_netdev_init(void) 
}

module_init(mhi_netdev_init);



static int __exit mhi_netdev_exit(void)

static void __exit mhi_netdev_exit(void)

{

	debugfs_remove_recursive(dentry);



	mhi_driver_unregister(&mhi_netdev_driver);

}

module_init(mhi_netdev_exit);

module_exit(mhi_netdev_exit);



MODULE_DESCRIPTION("MHI NETDEV Network Interface");

MODULE_LICENSE("GPL v2");

drivers/bus/mhi/devices/mhi_satellite.c

+2 −1
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/* Copyright (c) 2019, The Linux Foundation. All rights reserved.*/

/* Copyright (c) 2019-2020, The Linux Foundation. All rights reserved.*/



#include <linux/async.h>

#include <linux/device.h>
@@ -1201,6 +1201,7 @@ module_init(mhi_sat_init); 
static void __exit mhi_sat_exit(void)

{

	struct mhi_sat_subsys *subsys;

	int i;



	unregister_rpmsg_driver(&mhi_sat_rpmsg_driver);