Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5cc6ce9f authored by Anton Protopopov's avatar Anton Protopopov Committed by Pablo Neira Ayuso
Browse files

netfilter: nft_counter: fix erroneous return values 



The nft_counter_init() and nft_counter_clone() functions should return
negative error value -ENOMEM instead of positive ENOMEM.

Signed-off-by: default avatarAnton Protopopov <a.s.protopopov@gmail.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 08a7f5d3

net/netfilter/nft_counter.c

+2 −2
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ static int nft_counter_init(const struct nft_ctx *ctx, 


	cpu_stats = netdev_alloc_pcpu_stats(struct nft_counter_percpu);

	if (cpu_stats == NULL)

		return ENOMEM;

		return -ENOMEM;



	preempt_disable();

	this_cpu = this_cpu_ptr(cpu_stats);
@@ -138,7 +138,7 @@ static int nft_counter_clone(struct nft_expr *dst, const struct nft_expr *src) 
	cpu_stats = __netdev_alloc_pcpu_stats(struct nft_counter_percpu,

					      GFP_ATOMIC);

	if (cpu_stats == NULL)

		return ENOMEM;

		return -ENOMEM;



	preempt_disable();

	this_cpu = this_cpu_ptr(cpu_stats);