Commit 5c6021da authored Mar 15, 2016 by Leo Kim Committed by Greg Kroah-Hartman Mar 28, 2016

staging: wilc1000: removes goto definitions from wilc_wlan_firmware_download



This patch removes goto definitions from wilc_wlan_firmware_download function.
Goto '_fail_1' feature is error return.
It returns error type directly without result variable replacement as well.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 90fd4cc5

drivers/staging/wilc1000/wilc_wlan.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -946,10 +946,8 @@ int wilc_wlan_firmware_download(struct wilc wilc, const u8 buffer,
		blksz = BIT(12);

		dma_buffer = kmalloc(blksz, GFP_KERNEL);
		if (!dma_buffer) {
		ret = -EIO;
		goto _fail_1;
		}
		if (!dma_buffer)
		return -EIO;

		offset = 0;
		do {
		@@ -987,8 +985,6 @@ int wilc_wlan_firmware_download(struct wilc wilc, const u8 buffer,

		kfree(dma_buffer);

		_fail_1:

		return (ret < 0) ? ret : 0;
		}