Commit 5c4a5d3d authored Jul 21, 2018 by Todd Poynor Committed by Greg Kroah-Hartman Jul 24, 2018

staging: gasket: avoid copy to user on error in coherent alloc config



gasket_config_coherent_allocator() on error return the error to caller
without copying a possibly-update DMA address back to userspace.

Reported-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8fc1cb4c

drivers/staging/gasket/gasket_ioctl.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -441,8 +441,10 @@ static int gasket_config_coherent_allocator(
		gasket_dev, ibuf.size, &ibuf.dma_address,
		ibuf.page_table_index);
		}
		if (ret)
		return ret;
		if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
		return -EFAULT;

		return ret;
		return 0;
		}