Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c49ac3a authored by Janusz Krzysztofik's avatar Janusz Krzysztofik Committed by Mauro Carvalho Chehab
Browse files

media: ov6650: Fix device node exposed without proper locking 



Commit c62b9605 ("media: ov6650: Register with asynchronous
subdevice framework") carelessly requested creation of a video device
node by setting a V4L2_SUBDEV_FL_HAS_DEVNODE flag.  The driver is not
ready for that as it doesn't implement proper locking required for
serialization of IOCTLs.

Fix it by dropping the flag assignment.

Fixes: c62b9605 ("media: ov6650: Register with asynchronous subdevice framework")
Signed-off-by: default avatarJanusz Krzysztofik <jmkrzyszt@gmail.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 26092e7e

drivers/media/i2c/ov6650.c

+0 −1
Original line number Diff line number Diff line
@@ -1009,7 +1009,6 @@ static int ov6650_probe(struct i2c_client *client, 
	priv->colorspace  = V4L2_COLORSPACE_JPEG;



	priv->subdev.internal_ops = &ov6650_internal_ops;

	priv->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;



	ret = v4l2_async_register_subdev(&priv->subdev);

	if (ret)