Commit 5c331c86 authored Mar 04, 2014 by Thomas Gleixner

irqchip: xtensa: Select only an online cpu



The user space interface does not filter out offline cpus. It merily
verifies that the mask contains at least one online cpu. So the
selector in the irq chip implementation needs to make sure to pick
only an online cpu because otherwise:

     Offline Core 1
     Set affinity to 0xe
     Selector will pick first set bit, i.e. core 1

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Chris Zankel <chris@zankel.net>
Cc: xtensa <linux-xtensa@linux-xtensa.org>

parent 6decf1a3

drivers/irqchip/irq-xtensa-mx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -122,7 +122,7 @@ static int xtensa_mx_irq_retrigger(struct irq_data *d)
		static int xtensa_mx_irq_set_affinity(struct irq_data *d,
		const struct cpumask *dest, bool force)
		{
		unsigned mask = 1u << cpumask_any(dest);
		unsigned mask = 1u << cpumask_any_and(dest, cpu_online_mask);

		set_er(mask, MIROUT(d->hwirq - HW_IRQ_MX_BASE));
		return 0;