Commit 5c1d85c9 authored Mar 18, 2025 by Miaoqian Lin Committed by Greg Kroah-Hartman Jun 27, 2025

firmware: psci: Fix refcount leak in psci_dt_init



[ Upstream commit 7ff37d29fd5c27617b9767e1b8946d115cf93a1e ]

Fix a reference counter leak in psci_dt_init() where of_node_put(np) was
missing after of_find_matching_node_and_match() when np is unavailable.

Fixes: d09a0011 ("drivers: psci: Allow PSCI node to be disabled")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20250318151712.28763-1-linmq006@gmail.com


Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 629a2417

drivers/firmware/psci/psci.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -573,8 +573,10 @@ int __init psci_dt_init(void)

		np = of_find_matching_node_and_match(NULL, psci_of_match, &matched_np);

		if (!np \|\| !of_device_is_available(np))
		if (!np \|\| !of_device_is_available(np)) {
		of_node_put(np);
		return -ENODEV;
		}

		init_fn = (psci_initcall_t)matched_np->data;
		ret = init_fn(np);