Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5bf7295f authored by Aditya Pakki's avatar Aditya Pakki Committed by David S. Miller
Browse files

qlcnic: Avoid potential NULL pointer dereference 



netdev_alloc_skb can fail and return a NULL pointer which is
dereferenced without a check. The patch avoids such a scenario.

Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 58f2ce6f

drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c

+2 −0
Original line number Diff line number Diff line
@@ -1048,6 +1048,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode) 


	for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) {

		skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE);

		if (!skb)

			break;

		qlcnic_create_loopback_buff(skb->data, adapter->mac_addr);

		skb_put(skb, QLCNIC_ILB_PKT_SIZE);

		adapter->ahw->diag_cnt = 0;