Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5bdecd22 authored by Christof Schmitt's avatar Christof Schmitt Committed by James Bottomley
Browse files

[SCSI] zfcp: Remove duplicate assignment of req_seq_no 



zfcp_fsf_req_create assigns the same value twice to req_seq_no.
Remove one assignment and move the req_id and seq_no assignments to
one place.

Reviewed-by: default avatarSwen Schillig <swen@vnet.ibm.com>
Signed-off-by: default avatarChristof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent d21e9daa

drivers/s390/scsi/zfcp_fsf.c

+1 −2
Original line number Diff line number Diff line
@@ -741,6 +741,7 @@ static struct zfcp_fsf_req *zfcp_fsf_req_create(struct zfcp_qdio *qdio, 
			return ERR_PTR(-ENOMEM);

		}



		req->seq_no = adapter->fsf_req_seq_no;

		req->qtcb->prefix.req_seq_no = adapter->fsf_req_seq_no;

		req->qtcb->prefix.req_id = req->req_id;

		req->qtcb->prefix.ulp_info = 26;
@@ -748,8 +749,6 @@ static struct zfcp_fsf_req *zfcp_fsf_req_create(struct zfcp_qdio *qdio, 
		req->qtcb->prefix.qtcb_version = FSF_QTCB_CURRENT_VERSION;

		req->qtcb->header.req_handle = req->req_id;

		req->qtcb->header.fsf_command = req->fsf_command;

		req->seq_no = adapter->fsf_req_seq_no;

		req->qtcb->prefix.req_seq_no = adapter->fsf_req_seq_no;

		sbale[1].addr = (void *) req->qtcb;

		sbale[1].length = sizeof(struct fsf_qtcb);

	}