Commit 5bbe72cf authored Sep 16, 2019 by Navid Emamdoost Committed by Greg Kroah-Hartman Jan 14, 2020

rpmsg: char: release allocated memory



commit bbe692e349e2a1edf3fe0a29a0e05899c9c94d51 upstream.

In rpmsg_eptdev_write_iter, if copy_from_iter_full fails the allocated
buffer needs to be released.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3fe1ced4

drivers/rpmsg/rpmsg_char.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -227,8 +227,10 @@ static ssize_t rpmsg_eptdev_write_iter(struct kiocb *iocb,
		if (!kbuf)
		return -ENOMEM;

		if (!copy_from_iter_full(kbuf, len, from))
		return -EFAULT;
		if (!copy_from_iter_full(kbuf, len, from)) {
		ret = -EFAULT;
		goto free_kbuf;
		}

		if (mutex_lock_interruptible(&eptdev->ept_lock)) {
		ret = -ERESTARTSYS;