Commit 5ba8a4a9 authored Aug 25, 2016 by Dmitry Safonov Committed by Steven Rostedt Sep 01, 2016

tracing/uprobe: Drop isdigit() check in create_trace_uprobe

It's useless. Before:
  [tracing]# echo 'p:test /a:0x0' >> uprobe_events
  [tracing]# echo 'p:test a:0x0' >> uprobe_events
  -bash: echo: write error: No such file or directory
  [tracing]# echo 'p:test 1:0x0' >> uprobe_events
  -bash: echo: write error: Invalid argument

After:
  [tracing]# echo 'p:test 1:0x0' >> uprobe_events
  -bash: echo: write error: No such file or directory

Link: http://lkml.kernel.org/r/20160825152110.25663-3-dsafonov@virtuozzo.com



Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

parent 3eab887a

kernel/trace/trace_uprobe.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv)
		pr_info("Probe point is not specified.\n");
		return -EINVAL;
		}
		if (isdigit(argv[1][0])) {
		pr_info("probe point must be have a filename.\n");
		return -EINVAL;
		}
		arg = strchr(argv[1], ':');
		if (!arg) {
		ret = -EINVAL;