Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b72cf7a authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Greg Kroah-Hartman
Browse files

net: nixge: disable napi when enable interrupts failed in nixge_open() 



[ Upstream commit b06334919c7a068d54ba5b219c05e919d89943f7 ]

When failed to enable interrupts in nixge_open() for opening device,
napi isn't disabled. When open nixge device next time, it will reports
a invalid opcode issue. Fix it. Only be compiled, not be tested.

Fixes: 492caffa ("net: ethernet: nixge: Add support for National Instruments XGE netdev")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20221107101443.120205-1-shaozhengchao@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a8aade31

drivers/net/ethernet/ni/nixge.c

+1 −0
Original line number Diff line number Diff line
@@ -899,6 +899,7 @@ static int nixge_open(struct net_device *ndev) 
err_rx_irq:

	free_irq(priv->tx_irq, ndev);

err_tx_irq:

	napi_disable(&priv->napi);

	phy_stop(phy);

	phy_disconnect(phy);

	tasklet_kill(&priv->dma_err_tasklet);