Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b3306f0 authored by Naveen N. Rao's avatar Naveen N. Rao Committed by Michael Ellerman
Browse files

powerpc/pseries: Do not save the previous DTL mask value 



When CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is enabled, we always initialize
DTL enable mask to DTL_LOG_PREEMPT (0x2). There are no other places
where the mask is changed. As such, when reading the DTL log buffer
through debugfs, there is no need to save and restore the previous mask
value.

We don't need to save and restore the earlier mask value if
CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is not enabled. So, remove the field
from the structure as well.

Acked-by: default avatarNathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: default avatarNaveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 515bbc8a

arch/powerpc/platforms/pseries/dtl.c

+1 −3
Original line number Diff line number Diff line
@@ -55,7 +55,6 @@ struct dtl_ring { 
	struct dtl_entry *write_ptr;

	struct dtl_entry *buf;

	struct dtl_entry *buf_end;

	u8	saved_dtl_mask;

};



static DEFINE_PER_CPU(struct dtl_ring, dtl_rings);
@@ -105,7 +104,6 @@ static int dtl_start(struct dtl *dtl) 
	dtlr->write_ptr = dtl->buf;



	/* enable event logging */

	dtlr->saved_dtl_mask = lppaca_of(dtl->cpu).dtl_enable_mask;

	lppaca_of(dtl->cpu).dtl_enable_mask |= dtl_event_mask;



	dtl_consumer = consume_dtle;
@@ -123,7 +121,7 @@ static void dtl_stop(struct dtl *dtl) 
	dtlr->buf = NULL;



	/* restore dtl_enable_mask */

	lppaca_of(dtl->cpu).dtl_enable_mask = dtlr->saved_dtl_mask;

	lppaca_of(dtl->cpu).dtl_enable_mask = DTL_LOG_PREEMPT;



	if (atomic_dec_and_test(&dtl_count))

		dtl_consumer = NULL;