Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a81e6a1 authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Linus Torvalds
Browse files

vfs: fix uninitialized flags in splice_to_pipe() 



Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the
unused part of the pipe ring buffer.  Previously splice_to_pipe() left
the flags value alone, which could result in incorrect behavior.

Uninitialized flags appears to have been there from the introduction of
the splice syscall.

Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Cc: <stable@vger.kernel.org> # 2.6.17+
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 58f6eaee

fs/splice.c

+1 −0
Original line number Diff line number Diff line
@@ -204,6 +204,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe, 
		buf->len = spd->partial[page_nr].len;

		buf->private = spd->partial[page_nr].private;

		buf->ops = spd->ops;

		buf->flags = 0;



		pipe->nrbufs++;

		page_nr++;