Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a5e7c36 authored by Danny Kukawka's avatar Danny Kukawka Committed by David S. Miller
Browse files

xilinx ll_temac: use eth_hw_addr_random() instead of random_ether_addr() 



Use eth_hw_addr_random() instead of calling random_ether_addr()
to set addr_assign_type correctly to NET_ADDR_RANDOM.

Reset the state to NET_ADDR_PERM as soon as the MAC get
changed via .ndo_set_mac_address.

v2: reworked to prevent using an extra variable

Signed-off-by: default avatarDanny Kukawka <danny.kukawka@bisect.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent baf1d378

drivers/net/ethernet/xilinx/ll_temac_main.c

+3 −1
Original line number Diff line number Diff line
@@ -327,7 +327,9 @@ static int temac_set_mac_address(struct net_device *ndev, void *address) 
		memcpy(ndev->dev_addr, address, ETH_ALEN);



	if (!is_valid_ether_addr(ndev->dev_addr))

		random_ether_addr(ndev->dev_addr);

		eth_hw_addr_random(ndev);

	else

		dev->addr_assign_type &= ~NET_ADDR_RANDOM;



	/* set up unicast MAC address filter set its mac address */

	mutex_lock(&lp->indirect_mutex);