Commit 5a161419 authored Jun 07, 2021 by Yang Li Committed by Greg Kroah-Hartman Sep 22, 2021

NTB: Fix an error code in ntb_msit_probe()



[ Upstream commit 319f83ac98d7afaabab84ce5281a819a358b9895 ]

When the value of nm->isr_ctx is false, the value of ret is 0.
So, we set ret to -ENOMEM to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing
error code 'ret'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 09806979

drivers/ntb/test/ntb_msi_test.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -372,8 +372,10 @@ static int ntb_msit_probe(struct ntb_client client, struct ntb_dev ntb)
	if (ret)		if (ret)
	goto remove_dbgfs;		goto remove_dbgfs;

	if (!nm->isr_ctx)		if (!nm->isr_ctx) {
			ret = -ENOMEM;
	goto remove_dbgfs;		goto remove_dbgfs;
			}

	ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);		ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);