Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59d33f2f authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: serial: remove debug parameter from usb_serial_debug_data()



We should use dev_dbg() for usb_serial_debug_data() like all of the rest
of the usb-serial drivers use, so remove the debug parameter as it's not
needed.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 82760526
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -650,8 +650,7 @@ static void ark3116_read_int_callback(struct urb *urb)
		/*
		 * Not sure what this data meant...
		 */
		usb_serial_debug_data(debug, &port->dev,
				      __func__,
		usb_serial_debug_data(&port->dev, __func__,
				      urb->actual_length,
				      urb->transfer_buffer);
		break;
+1 −2
Original line number Diff line number Diff line
@@ -206,8 +206,7 @@ static void belkin_sa_read_int_callback(struct urb *urb)
		goto exit;
	}

	usb_serial_debug_data(debug, &port->dev, __func__,
					urb->actual_length, data);
	usb_serial_debug_data(&port->dev, __func__, urb->actual_length, data);

	/* Handle known interrupt data */
	/* ignore data[0] and data[1] */
+1 −1
Original line number Diff line number Diff line
@@ -463,7 +463,7 @@ static void ch341_read_int_callback(struct urb *urb)
		goto exit;
	}

	usb_serial_debug_data(debug, &port->dev, __func__,
	usb_serial_debug_data(&port->dev, __func__,
			      urb->actual_length, urb->transfer_buffer);

	if (actual_length >= 4) {
+3 −5
Original line number Diff line number Diff line
@@ -222,8 +222,7 @@ static int cyberjack_write(struct tty_struct *tty,
	/* Copy data */
	memcpy(priv->wrbuf + priv->wrfilled, buf, count);

	usb_serial_debug_data(debug, dev, __func__, count,
		priv->wrbuf + priv->wrfilled);
	usb_serial_debug_data(dev, __func__, count, priv->wrbuf + priv->wrfilled);
	priv->wrfilled += count;

	if (priv->wrfilled >= 3) {
@@ -295,7 +294,7 @@ static void cyberjack_read_int_callback(struct urb *urb)
	if (status)
		return;

	usb_serial_debug_data(debug, dev, __func__, urb->actual_length, data);
	usb_serial_debug_data(dev, __func__, urb->actual_length, data);

	/* React only to interrupts signaling a bulk_in transfer */
	if (urb->actual_length == 4 && data[0] == 0x01) {
@@ -348,8 +347,7 @@ static void cyberjack_read_bulk_callback(struct urb *urb)
	int result;
	int status = urb->status;

	usb_serial_debug_data(debug, &port->dev, __func__,
						urb->actual_length, data);
	usb_serial_debug_data(dev, __func__, urb->actual_length, data);
	if (status) {
		dev_dbg(dev, "%s - nonzero read bulk status received: %d\n",
			__func__, status);
+3 −5
Original line number Diff line number Diff line
@@ -769,8 +769,7 @@ static void cypress_send(struct usb_serial_port *port)
		actual_size = count +
			      (priv->pkt_fmt == packet_format_1 ? 2 : 1);

	usb_serial_debug_data(debug, &port->dev, __func__,
		port->interrupt_out_size,
	usb_serial_debug_data(dev, __func__, port->interrupt_out_size,
			      port->interrupt_out_urb->transfer_buffer);

	usb_fill_int_urb(port->interrupt_out_urb, port->serial->dev,
@@ -1187,8 +1186,7 @@ static void cypress_read_int_callback(struct urb *urb)
		goto continue_read;
	}

	usb_serial_debug_data(debug, &port->dev, __func__,
						urb->actual_length, data);
	usb_serial_debug_data(&port->dev, __func__, urb->actual_length, data);

	spin_lock_irqsave(&priv->lock, flags);
	/* check to see if status has changed */
Loading