Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59bfee6e authored by Wolfram Sang's avatar Wolfram Sang Committed by Jean Delvare
Browse files

i2c: Remove obsolete cleanup for clientdata 



A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit. This is obsolete meanwhile, so fix it and hope the word will spread.

Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent 4193d916

drivers/misc/bh1780gli.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -190,7 +190,6 @@ static int __devexit bh1780_remove(struct i2c_client *client) 




	ddata = i2c_get_clientdata(client);

	ddata = i2c_get_clientdata(client);

	sysfs_remove_group(&client->dev.kobj, &bh1780_attr_group);

	sysfs_remove_group(&client->dev.kobj, &bh1780_attr_group);

	i2c_set_clientdata(client, NULL);

	kfree(ddata);

	kfree(ddata);





	return 0;

	return 0;

drivers/regulator/ad5398.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -256,7 +256,6 @@ static int __devexit ad5398_remove(struct i2c_client *client) 




	regulator_unregister(chip->rdev);

	regulator_unregister(chip->rdev);

	kfree(chip);

	kfree(chip);

	i2c_set_clientdata(client, NULL);





	return 0;

	return 0;

}

}

drivers/regulator/isl6271a-regulator.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -191,8 +191,6 @@ static int __devexit isl6271a_remove(struct i2c_client *i2c) 
	struct isl_pmic *pmic = i2c_get_clientdata(i2c);

	struct isl_pmic *pmic = i2c_get_clientdata(i2c);

	int i;

	int i;





	i2c_set_clientdata(i2c, NULL);



	for (i = 0; i < 3; i++)

	for (i = 0; i < 3; i++)

		regulator_unregister(pmic->rdev[i]);

		regulator_unregister(pmic->rdev[i]);

drivers/rtc/rtc-ds3232.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -268,7 +268,6 @@ static int __devinit ds3232_probe(struct i2c_client *client, 
		free_irq(client->irq, client);

		free_irq(client->irq, client);





out_free:

out_free:

	i2c_set_clientdata(client, NULL);

	kfree(ds3232);

	kfree(ds3232);

	return ret;

	return ret;

}

}
@@ -287,7 +286,6 @@ static int __devexit ds3232_remove(struct i2c_client *client) 
	}

	}





	rtc_device_unregister(ds3232->rtc);

	rtc_device_unregister(ds3232->rtc);

	i2c_set_clientdata(client, NULL);

	kfree(ds3232);

	kfree(ds3232);

	return 0;

	return 0;

}

}