Commit 5989a55a authored Sep 23, 2014 by Jason Gerecke Committed by Jiri Kosina Oct 29, 2014

HID: input: Fix TransducerSerialNumber implementation

The commit which introduced TransducerSerialNumber (368c9664) is missing
two crucial implementation details. Firstly, the commit does not set the
type/code/bit/max fields as expected later down the code which can cause
the driver to crash when a tablet with this usage is connected. Secondly,
the call to 'set_bit' causes MSC_PULSELED to be sent instead of the
expected MSC_SERIAL. This commit addreses both issues.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: Ping Cheng <pingc@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent f974008f

drivers/hid/hid-input.c

+4 −1

Original line number	Original line	Diff line number	Diff line
	@@ -695,7 +695,10 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
	break;		break;

	case 0x5b: /* TransducerSerialNumber */		case 0x5b: /* TransducerSerialNumber */
	set_bit(MSC_SERIAL, input->mscbit);		usage->type = EV_MSC;
			usage->code = MSC_SERIAL;
			bit = input->mscbit;
			max = MSC_MAX;
	break;		break;

	default: goto unknown;		default: goto unknown;