Commit 59663a4c authored Dec 21, 2015 by Linus Walleij

pinctrl: spmi-mpp: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Björn Andersson <bjorn.andersson@sonymobile.com>
Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 86c1a219

drivers/pinctrl/qcom/pinctrl-spmi-mpp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -591,7 +591,7 @@ static int pmic_mpp_get(struct gpio_chip *chip, unsigned pin)
		pad->out_value = ret & PMIC_MPP_REG_RT_STS_VAL_MASK;
		}

		return pad->out_value;
		return !!pad->out_value;
		}

		static void pmic_mpp_set(struct gpio_chip *chip, unsigned pin, int value)