Commit 59579a8d authored Apr 17, 2019 by Jiri Kosina

HID: u2fzero: fail probe if not using USB transport



u2fzero driver is USB-only. Therefore we have to give up in ->probe()
callback in case we're called with non-USB transport driver bound,
otherwise the kernel will crash trying to use USBHID API on a non-USB
transport.

Fixes: 42337b9d("HID: add driver for U2F Zero built-in LED and RNG")
Reported-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent e252e0e0

drivers/hid/hid-u2fzero.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -286,6 +286,9 @@ static int u2fzero_probe(struct hid_device *hdev,
		unsigned int minor;
		int ret;

		if (!hid_is_using_ll_driver(hdev, &usb_hid_driver))
		return -EINVAL;

		dev = devm_kzalloc(&hdev->dev, sizeof(*dev), GFP_KERNEL);
		if (dev == NULL)
		return -ENOMEM;