Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59348f14 authored by Dinghao Liu's avatar Dinghao Liu Committed by Greg Kroah-Hartman
Browse files

scsi: be2iscsi: Fix a memleak in beiscsi_init_wrb_handle() 



[ Upstream commit 235f2b548d7f4ac5931d834f05d3f7f5166a2e72 ]

When an error occurs in the for loop of beiscsi_init_wrb_handle(), we
should free phwi_ctxt->be_wrbq before returning an error code to prevent
potential memleak.

Fixes: a7909b39 ("[SCSI] be2iscsi: Fix dynamic CID allocation Mechanism in driver")
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20231123081941.24854-1-dinghao.liu@zju.edu.cn


Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 8244ea91

drivers/scsi/be2iscsi/be_main.c

+1 −0
Original line number Diff line number Diff line
@@ -2694,6 +2694,7 @@ static int beiscsi_init_wrb_handle(struct beiscsi_hba *phba) 
		kfree(pwrb_context->pwrb_handle_base);

		kfree(pwrb_context->pwrb_handle_basestd);

	}

	kfree(phwi_ctxt->be_wrbq);

	return -ENOMEM;

}