Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5925179b authored by Sean Young's avatar Sean Young Committed by Greg Kroah-Hartman
Browse files

media: rc: do not access device via sysfs after rc_unregister_device() 



commit a2e2d73fa28136598e84db9d021091f1b98cbb1a upstream.

Device drivers do not expect to have change_protocol or wakeup
re-programming to be accesed after rc_unregister_device(). This can
cause the device driver to access deallocated resources.

Cc: <stable@vger.kernel.org> # 4.16+
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3d77c12f

drivers/media/rc/rc-main.c

+12 −0
Original line number Diff line number Diff line
@@ -1256,6 +1256,10 @@ static ssize_t store_protocols(struct device *device, 
	}



	mutex_lock(&dev->lock);

	if (!dev->registered) {

		mutex_unlock(&dev->lock);

		return -ENODEV;

	}



	old_protocols = *current_protocols;

	new_protocols = old_protocols;
@@ -1394,6 +1398,10 @@ static ssize_t store_filter(struct device *device, 
		return -EINVAL;



	mutex_lock(&dev->lock);

	if (!dev->registered) {

		mutex_unlock(&dev->lock);

		return -ENODEV;

	}



	new_filter = *filter;

	if (fattr->mask)
@@ -1508,6 +1516,10 @@ static ssize_t store_wakeup_protocols(struct device *device, 
	int i;



	mutex_lock(&dev->lock);

	if (!dev->registered) {

		mutex_unlock(&dev->lock);

		return -ENODEV;

	}



	allowed = dev->allowed_wakeup_protocols;