Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 58e42ee4 authored by Jiasheng Jiang's avatar Jiasheng Jiang Committed by Greg Kroah-Hartman
Browse files

ASoC: fsi: Add check for clk_enable 



[ Upstream commit 405afed8a728f23cfaa02f75bbc8bdd6b7322123 ]

As the potential failure of the clk_enable(),
it should be better to check it and return error
if fails.

Fixes: ab6f6d85 ("ASoC: fsi: add master clock control functions")
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220302062844.46869-1-jiasheng@iscas.ac.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ea9adaa5

sound/soc/sh/fsi.c

+16 −3
Original line number Diff line number Diff line
@@ -816,14 +816,27 @@ static int fsi_clk_enable(struct device *dev, 
			return ret;

		}



		clk_enable(clock->xck);

		clk_enable(clock->ick);

		clk_enable(clock->div);

		ret = clk_enable(clock->xck);

		if (ret)

			goto err;

		ret = clk_enable(clock->ick);

		if (ret)

			goto disable_xck;

		ret = clk_enable(clock->div);

		if (ret)

			goto disable_ick;



		clock->count++;

	}



	return ret;



disable_ick:

	clk_disable(clock->ick);

disable_xck:

	clk_disable(clock->xck);

err:

	return ret;

}



static int fsi_clk_disable(struct device *dev,