Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 583bbf46 authored by Steven Price's avatar Steven Price Committed by Rob Herring
Browse files

drm/panfrost: Use drm_gem_map_offset() 



panfrost_ioctl_mmap_bo() contains a reimplementation of
drm_gem_map_offset() but with a bug - it allows mapping imported
objects (without going through the exporter). Fix this by switching to
use the newly renamed drm_gem_map_offset() function instead which has
the bonus of simplifying the code.

Signed-off-by: default avatarSteven Price <steven.price@arm.com>
Reviewed-by: default avatarAlyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190627155318.38053-3-steven.price@arm.com
parent 220df83a

drivers/gpu/drm/panfrost/panfrost_drv.c

+2 −14
Original line number Diff line number Diff line
@@ -259,26 +259,14 @@ static int panfrost_ioctl_mmap_bo(struct drm_device *dev, void *data, 
		      struct drm_file *file_priv)

{

	struct drm_panfrost_mmap_bo *args = data;

	struct drm_gem_object *gem_obj;

	int ret;



	if (args->flags != 0) {

		DRM_INFO("unknown mmap_bo flags: %d\n", args->flags);

		return -EINVAL;

	}



	gem_obj = drm_gem_object_lookup(file_priv, args->handle);

	if (!gem_obj) {

		DRM_DEBUG("Failed to look up GEM BO %d\n", args->handle);

		return -ENOENT;

	}



	ret = drm_gem_create_mmap_offset(gem_obj);

	if (ret == 0)

		args->offset = drm_vma_node_offset_addr(&gem_obj->vma_node);

	drm_gem_object_put_unlocked(gem_obj);



	return ret;

	return drm_gem_map_offset(file_priv, dev, args->handle,

				       &args->offset);

}



static int panfrost_ioctl_get_bo_offset(struct drm_device *dev, void *data,