Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57e3a5f2 authored by Arthur Kiyanovski's avatar Arthur Kiyanovski Committed by David S. Miller
Browse files

net: ena: remove code duplication in ena_com_update_nonadaptive_moderation_interval _*() 



Remove code duplication in:
ena_com_update_nonadaptive_moderation_interval_tx()
ena_com_update_nonadaptive_moderation_interval_rx()
functions.

Signed-off-by: default avatarArthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bd21b0cc

drivers/net/ethernet/amazon/ena/ena_com.c

+16 −14
Original line number Diff line number Diff line
@@ -2772,32 +2772,34 @@ bool ena_com_interrupt_moderation_supported(struct ena_com_dev *ena_dev) 
						  ENA_ADMIN_INTERRUPT_MODERATION);

}



int ena_com_update_nonadaptive_moderation_interval_tx(struct ena_com_dev *ena_dev,

						      u32 tx_coalesce_usecs)

static int ena_com_update_nonadaptive_moderation_interval(u32 coalesce_usecs,

							  u32 intr_delay_resolution,

							  u32 *intr_moder_interval)

{

	if (!ena_dev->intr_delay_resolution) {

	if (!intr_delay_resolution) {

		pr_err("Illegal interrupt delay granularity value\n");

		return -EFAULT;

	}



	ena_dev->intr_moder_tx_interval = tx_coalesce_usecs /

		ena_dev->intr_delay_resolution;

	*intr_moder_interval = coalesce_usecs / intr_delay_resolution;



	return 0;

}



int ena_com_update_nonadaptive_moderation_interval_rx(struct ena_com_dev *ena_dev,

						      u32 rx_coalesce_usecs)

int ena_com_update_nonadaptive_moderation_interval_tx(struct ena_com_dev *ena_dev,

						      u32 tx_coalesce_usecs)

{

	if (!ena_dev->intr_delay_resolution) {

		pr_err("Illegal interrupt delay granularity value\n");

		return -EFAULT;

	return ena_com_update_nonadaptive_moderation_interval(tx_coalesce_usecs,

							      ena_dev->intr_delay_resolution,

							      &ena_dev->intr_moder_tx_interval);

}



	ena_dev->intr_moder_rx_interval = rx_coalesce_usecs /

		ena_dev->intr_delay_resolution;



	return 0;

int ena_com_update_nonadaptive_moderation_interval_rx(struct ena_com_dev *ena_dev,

						      u32 rx_coalesce_usecs)

{

	return ena_com_update_nonadaptive_moderation_interval(rx_coalesce_usecs,

							      ena_dev->intr_delay_resolution,

							      &ena_dev->intr_moder_rx_interval);

}



void ena_com_destroy_interrupt_moderation(struct ena_com_dev *ena_dev)