Commit 57c8e2ea authored Aug 11, 2021 by Zhen Lei Committed by Greg Kroah-Hartman Sep 15, 2021

genirq/timings: Fix error return code in irq_timings_test_irqs()



[ Upstream commit 290fdc4b7ef14e33d0e30058042b0e9bfd02b89b ]

Return a negative error code from the error handling case instead of 0, as
done elsewhere in this function.

Fixes: f52da98d ("genirq/timings: Add selftest for irqs circular buffer")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2d00b22c

kernel/irq/timings.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -799,12 +799,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)

		__irq_timings_store(irq, irqs, ti->intervals[i]);
		if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
		ret = -EBADSLT;
		pr_err("Failed to store in the circular buffer\n");
		goto out;
		}
		}

		if (irqs->count != ti->count) {
		ret = -ERANGE;
		pr_err("Count differs\n");
		goto out;
		}