Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57b0ad4f authored by Qasim Ijaz's avatar Qasim Ijaz Committed by Greg Kroah-Hartman
Browse files

HID: wacom: fix kobject reference count leak 



commit 85a720f4337f0ddf1603c8b75a8f1ffbbe022ef9 upstream.

When sysfs_create_files() fails in wacom_initialize_remotes() the error
is returned and the cleanup action will not have been registered yet.

As a result the kobject???s refcount is never dropped, so the
kobject can never be freed leading to a reference leak.

Fix this by calling kobject_put() before returning.

Fixes: 83e6b40e ("HID: wacom: EKR: have the wacom resources dynamically allocated")
Acked-by: default avatarPing Cheng <ping.cheng@wacom.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarQasim Ijaz <qasdev00@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ee49c0e9

drivers/hid/wacom_sys.c

+1 −0
Original line number Diff line number Diff line
@@ -2031,6 +2031,7 @@ static int wacom_initialize_remotes(struct wacom *wacom) 
		hid_err(wacom->hdev,

			"cannot create sysfs group err: %d\n", error);

		kfifo_free(&remote->remote_fifo);

		kobject_put(remote->remote_dir);

		return error;

	}