Commit 5760f427 authored Apr 11, 2013 by Silviu-Mihai Popescu Committed by David S. Miller Apr 11, 2013

net: ethernet: stmicro: stmmac: use devm_ioremap_resource()



Convert  use of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.

This was found with coccinelle.

Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f9725c03

drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -88,11 +88,9 @@ static int stmmac_pltfr_probe(struct platform_device *pdev)
		if (!res)
		return -ENODEV;

		addr = devm_request_and_ioremap(dev, res);
		if (!addr) {
		pr_err("%s: ERROR: memory mapping failed", __func__);
		return -ENOMEM;
		}
		addr = devm_ioremap_resource(dev, res);
		if (IS_ERR(addr))
		return PTR_ERR(addr);

		if (pdev->dev.of_node) {
		plat_dat = devm_kzalloc(&pdev->dev,