Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 570cec32 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm: Reject fbs w/o format info in drm_framebuffer_init() 



Any framebuffer that doesn't have proper format information when
drm_framebuffer_init() is called is a bug. Let's warn and return
an error to avoid oopsing the kernel later due to dereferencing the
NULL fb->format pointer.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Suggested-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1479498793-31021-23-git-send-email-ville.syrjala@linux.intel.com


Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
parent 2f3f4763

drivers/gpu/drm/drm_framebuffer.c

+1 −1
Original line number Diff line number Diff line
@@ -631,7 +631,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb, 
{

	int ret;



	if (WARN_ON_ONCE(fb->dev != dev))

	if (WARN_ON_ONCE(fb->dev != dev || !fb->format))

		return -EINVAL;



	INIT_LIST_HEAD(&fb->filp_head);