Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56e027a6 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Doug Ledford
Browse files

ib_srp: Remove WARN_ON in srp_terminate_io() 



The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
at that time, so no new commands can be submitted via srp_queuecommand()

Signed-off-by: default avatarHannes Reinecke <hare@suse.com>
Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.com>
Acked-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 6f4bc0ea

drivers/infiniband/ulp/srp/ib_srp.c

+0 −9
Original line number Diff line number Diff line
@@ -1330,17 +1330,8 @@ static void srp_terminate_io(struct srp_rport *rport) 
{

	struct srp_target_port *target = rport->lld_data;

	struct srp_rdma_ch *ch;

	struct Scsi_Host *shost = target->scsi_host;

	struct scsi_device *sdev;

	int i, j;



	/*

	 * Invoking srp_terminate_io() while srp_queuecommand() is running

	 * is not safe. Hence the warning statement below.

	 */

	shost_for_each_device(sdev, shost)

		WARN_ON_ONCE(sdev->request_queue->request_fn_active);



	for (i = 0; i < target->ch_count; i++) {

		ch = &target->ch[i];