Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56c85e6b authored by Joe Hattori's avatar Joe Hattori Committed by Greg Kroah-Hartman
Browse files

iio: inkern: call iio_device_put() only on mapped devices 



commit 64f43895b4457532a3cc524ab250b7a30739a1b1 upstream.

In the error path of iio_channel_get_all(), iio_device_put() is called
on all IIO devices, which can cause a refcount imbalance. Fix this error
by calling iio_device_put() only on IIO devices whose refcounts were
previously incremented by iio_device_get().

Fixes: 314be14b ("iio: Rename _st_ functions to loose the bit that meant the staging version.")
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://patch.msgid.link/20241204111342.1246706-1-joe@pf.is.s.u-tokyo.ac.jp


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b549c90b

drivers/iio/inkern.c

+1 −1
Original line number Diff line number Diff line
@@ -466,7 +466,7 @@ struct iio_channel *iio_channel_get_all(struct device *dev) 
	return chans;



error_free_chans:

	for (i = 0; i < nummaps; i++)

	for (i = 0; i < mapind; i++)

		iio_device_put(chans[i].indio_dev);

	kfree(chans);

error_ret: