Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56b854bb authored by James Bottomley's avatar James Bottomley
Browse files

[SCSI] fcoe: fix incorrect use of struct module 



This structure may not be defined if CONFIG_MODULE=n, so never deref
it.  Change uses of module->name to module_name(module) and corrects
some dyslexic printks and docbook comments.

Reported-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
Cc: Robert Love <robert.w.love@intel.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 73c33674

drivers/scsi/fcoe/libfcoe.c

+5 −5
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ static int fcoe_cpu_callback(struct notifier_block *nfb, unsigned long action, 
#endif /* CONFIG_HOTPLUG_CPU */



/**

 * foce_rcv - this is the fcoe receive function called by NET_RX_SOFTIRQ

 * fcoe_rcv - this is the fcoe receive function called by NET_RX_SOFTIRQ

 * @skb: the receive skb

 * @dev: associated net device

 * @ptype: context
@@ -991,8 +991,8 @@ static int fcoe_ethdrv_get(const struct net_device *netdev) 


	owner = fcoe_netdev_to_module_owner(netdev);

	if (owner) {

		printk(KERN_DEBUG "foce:hold driver module %s for %s\n",

		       owner->name, netdev->name);

		printk(KERN_DEBUG "fcoe:hold driver module %s for %s\n",

		       module_name(owner), netdev->name);

		return  try_module_get(owner);

	}

	return -ENODEV;
@@ -1011,8 +1011,8 @@ static int fcoe_ethdrv_put(const struct net_device *netdev) 


	owner = fcoe_netdev_to_module_owner(netdev);

	if (owner) {

		printk(KERN_DEBUG "foce:release driver module %s for %s\n",

		       owner->name, netdev->name);

		printk(KERN_DEBUG "fcoe:release driver module %s for %s\n",

		       module_name(owner), netdev->name);

		module_put(owner);

		return 0;

	}