Commit 56526c38 authored Jun 01, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Jun 22, 2022

irqchip/gic/realview: Fix refcount leak in realview_gic_of_init



[ Upstream commit f4b98e314888cc51486421bcf6d52852452ea48b ]

of_find_matching_node_and_match() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 82b0a434 ("irqchip/gic/realview: Support more RealView DCC variants")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-2-linmq006@gmail.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4695bafa

drivers/irqchip/irq-gic-realview.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node node, struct device_node parent)

	/* The PB11MPCore GIC needs to be configured in the syscon */		/* The PB11MPCore GIC needs to be configured in the syscon */
	map = syscon_node_to_regmap(np);		map = syscon_node_to_regmap(np);
			of_node_put(np);
	if (!IS_ERR(map)) {		if (!IS_ERR(map)) {
	/* new irq mode with no DCC */		/* new irq mode with no DCC */
	regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,		regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,