Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5640f768 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: use a per task frag allocator 



We currently use a per socket order-0 page cache for tcp_sendmsg()
operations.

This page is used to build fragments for skbs.

Its done to increase probability of coalescing small write() into
single segments in skbs still in write queue (not yet sent)

But it wastes a lot of memory for applications handling many mostly
idle sockets, since each socket holds one page in sk->sk_sndmsg_page

Its also quite inefficient to build TSO 64KB packets, because we need
about 16 pages per skb on arches where PAGE_SIZE = 4096, so we hit
page allocator more than wanted.

This patch adds a per task frag allocator and uses bigger pages,
if available. An automatic fallback is done in case of memory pressure.

(up to 32768 bytes per frag, thats order-3 pages on x86)

This increases TCP stream performance by 20% on loopback device,
but also benefits on other network devices, since 8x less frags are
mapped on transmit and unmapped on tx completion. Alexander Duyck
mentioned a probable performance win on systems with IOMMU enabled.

Its possible some SG enabled hardware cant cope with bigger fragments,
but their ndo_start_xmit() should already handle this, splitting a
fragment in sub fragments, since some arches have PAGE_SIZE=65536

Successfully tested on various ethernet devices.
(ixgbe, igb, bnx2x, tg3, mellanox mlx4)

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Cc: Vijay Subramanian <subramanian.vijay@gmail.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: default avatarVijay Subramanian <subramanian.vijay@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b98b8bab

include/linux/sched.h

+3 −0
Original line number Diff line number Diff line
@@ -1530,6 +1530,9 @@ struct task_struct { 
	 * cache last used pipe for splice

	 */

	struct pipe_inode_info *splice_pipe;



	struct page_frag task_frag;



#ifdef	CONFIG_TASK_DELAY_ACCT

	struct task_delay_info *delays;

#endif

include/net/inet_sock.h

+1 −3
Original line number Diff line number Diff line
@@ -101,10 +101,8 @@ struct inet_cork { 
	__be32			addr;

	struct ip_options	*opt;

	unsigned int		fragsize;

	struct dst_entry	*dst;

	int			length; /* Total length of all frames */

	struct page		*page;

	u32			off;

	struct dst_entry	*dst;

	u8			tx_flags;

};

include/net/sock.h

+15 −12
Original line number Diff line number Diff line
@@ -247,8 +247,7 @@ struct cg_proto; 
  *	@sk_stamp: time stamp of last packet received

  *	@sk_socket: Identd and reporting IO signals

  *	@sk_user_data: RPC layer private data

  *	@sk_sndmsg_page: cached page for sendmsg

  *	@sk_sndmsg_off: cached offset for sendmsg

  *	@sk_frag: cached page frag

  *	@sk_peek_off: current peek_offset value

  *	@sk_send_head: front of stuff to transmit

  *	@sk_security: used by security modules
@@ -362,9 +361,8 @@ struct sock { 
	ktime_t			sk_stamp;

	struct socket		*sk_socket;

	void			*sk_user_data;

	struct page		*sk_sndmsg_page;

	struct page_frag	sk_frag;

	struct sk_buff		*sk_send_head;

	__u32			sk_sndmsg_off;

	__s32			sk_peek_off;

	int			sk_write_pending;

#ifdef CONFIG_SECURITY
@@ -2034,18 +2032,23 @@ static inline void sk_stream_moderate_sndbuf(struct sock *sk) 


struct sk_buff *sk_stream_alloc_skb(struct sock *sk, int size, gfp_t gfp);



static inline struct page *sk_stream_alloc_page(struct sock *sk)

/**

 * sk_page_frag - return an appropriate page_frag

 * @sk: socket

 *

 * If socket allocation mode allows current thread to sleep, it means its

 * safe to use the per task page_frag instead of the per socket one.

 */

static inline struct page_frag *sk_page_frag(struct sock *sk)

{

	struct page *page = NULL;

	if (sk->sk_allocation & __GFP_WAIT)

		return &current->task_frag;



	page = alloc_pages(sk->sk_allocation, 0);

	if (!page) {

		sk_enter_memory_pressure(sk);

		sk_stream_moderate_sndbuf(sk);

	}

	return page;

	return &sk->sk_frag;

}



extern bool sk_page_frag_refill(struct sock *sk, struct page_frag *pfrag);



/*

 *	Default write policy as shown to user space via poll/select/SIGIO

 */

kernel/exit.c

+3 −0
Original line number Diff line number Diff line
@@ -1046,6 +1046,9 @@ void do_exit(long code) 
	if (tsk->splice_pipe)

		__free_pipe_info(tsk->splice_pipe);



	if (tsk->task_frag.page)

		put_page(tsk->task_frag.page);



	validate_creds_for_do_exit(tsk);



	preempt_disable();

kernel/fork.c

+1 −0
Original line number Diff line number Diff line
@@ -330,6 +330,7 @@ static struct task_struct *dup_task_struct(struct task_struct *orig) 
	tsk->btrace_seq = 0;

#endif

	tsk->splice_pipe = NULL;

	tsk->task_frag.page = NULL;



	account_kernel_stack(ti, 1);