Commit 55317f5b authored Apr 29, 2019 by Bob Peterson Committed by Andreas Gruenbacher Jun 27, 2019

gfs2: simplify gfs2_freeze by removing case



Function gfs2_freeze had a case statement that simply checked the
error code, but the break statements just made the logic hard to
read. This patch simplifies the logic in favor of a simple if.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

parent 04aea0ca

fs/gfs2/super.c

+2 −8

Original line number	Diff line number	Diff line
		@@ -1023,20 +1023,14 @@ static int gfs2_freeze(struct super_block *sb)
		if (!error)
		break;

		switch (error) {
		case -EBUSY:
		if (error == -EBUSY)
		fs_err(sdp, "waiting for recovery before freeze\n");
		break;

		default:
		else
		fs_err(sdp, "error freezing FS: %d\n", error);
		break;
		}

		fs_err(sdp, "retrying...\n");
		msleep(1000);
		}
		error = 0;
		set_bit(SDF_FS_FROZEN, &sdp->sd_flags);
		out:
		mutex_unlock(&sdp->sd_freeze_mutex);