Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5516df10 authored by Asutosh Das's avatar Asutosh Das
Browse files

scsi: ufs-qcom: add qos support for ufs 



Adds support for QoS.
At init, vote for maximum latency S32_MAX.
Schedule a vote of PERF when a request is received.
Update the vote to S32_MAX during clock gating.

Change-Id: I91ed683880a00493f4bd510689e5037939ce6661
Signed-off-by: default avatarAsutosh Das <asutoshd@codeaurora.org>
parent 8f161b7b

drivers/scsi/ufs/ufs-qcom.c

+282 −0
Original line number Original line Diff line number Diff line
@@ -14,6 +14,8 @@ 
#include <linux/interconnect.h>

#include <linux/interconnect.h>

#include <linux/phy/phy-qcom-ufs.h>

#include <linux/phy/phy-qcom-ufs.h>

#include <linux/devfreq.h>

#include <linux/devfreq.h>

#include <linux/cpu.h>

#include <linux/blk-mq.h>





#include "ufshcd.h"

#include "ufshcd.h"

#include "ufshcd-pltfrm.h"

#include "ufshcd-pltfrm.h"
@@ -76,6 +78,9 @@ static void ufs_qcom_parse_limits(struct ufs_qcom_host *host); 
static void ufs_qcom_parse_lpm(struct ufs_qcom_host *host);

static void ufs_qcom_parse_lpm(struct ufs_qcom_host *host);

static int ufs_qcom_set_dme_vs_core_clk_ctrl_max_freq_mode(struct ufs_hba *hba);

static int ufs_qcom_set_dme_vs_core_clk_ctrl_max_freq_mode(struct ufs_hba *hba);

static int ufs_qcom_init_sysfs(struct ufs_hba *hba);

static int ufs_qcom_init_sysfs(struct ufs_hba *hba);

static int ufs_qcom_update_qos_constraints(struct qos_cpu_group *qcg,

					   enum constraint type);

static int ufs_qcom_unvote_qos_all(struct ufs_hba *hba);





static int ufs_qcom_get_pwr_dev_param(struct ufs_qcom_dev_params *qcom_param,

static int ufs_qcom_get_pwr_dev_param(struct ufs_qcom_dev_params *qcom_param,

				      struct ufs_pa_layer_attr *dev_max,

				      struct ufs_pa_layer_attr *dev_max,
@@ -933,6 +938,45 @@ static int ufs_qcom_disable_vreg(struct device *dev, struct ufs_vreg *vreg) 
	return ret;

	return ret;

}

}





static int add_group_qos(struct qos_cpu_group *qcg, enum constraint type)

{

	int cpu, err;

	struct dev_pm_qos_request *qos_req = qcg->qos_req;



	for_each_cpu(cpu, &qcg->mask) {

		dev_dbg(qcg->host->hba->dev, "%s: cpu: %d | mask: 0x%08x | assoc-qos-req: 0x%08x\n",

			__func__, cpu, qcg->mask, qos_req);

		memset(qos_req, 0,

		       sizeof(struct dev_pm_qos_request));

		err = dev_pm_qos_add_request(get_cpu_device(cpu),

					     qos_req,

					     DEV_PM_QOS_RESUME_LATENCY,

					     type);

		if (err < 0)

			return err;

		qos_req++;

	}

	return 0;

}



static int remove_group_qos(struct qos_cpu_group *qcg)

{

	int err, cpu;

	struct dev_pm_qos_request *qos_req = qcg->qos_req;



	for_each_cpu(cpu, &qcg->mask) {

		if (!dev_pm_qos_request_active(qos_req)) {

			qos_req++;

			continue;

		}

		err = dev_pm_qos_remove_request(qos_req);

		if (err < 0)

			return err;

		qos_req++;

	}

	return 0;

}



static int ufs_qcom_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)

static int ufs_qcom_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)

{

{

	struct ufs_qcom_host *host = ufshcd_get_variant(hba);

	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
@@ -951,6 +995,8 @@ static int ufs_qcom_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op) 
		if (host->vccq_parent && !hba->auto_bkops_enabled)

		if (host->vccq_parent && !hba->auto_bkops_enabled)

			ufs_qcom_config_vreg(hba->dev,

			ufs_qcom_config_vreg(hba->dev,

					host->vccq_parent, false);

					host->vccq_parent, false);

		if (!err)

			err = ufs_qcom_unvote_qos_all(hba);

	}

	}





	return err;

	return err;
@@ -1668,6 +1714,29 @@ static void ufs_qcom_set_caps(struct ufs_hba *hba) 
	}

	}

}

}





static int ufs_qcom_unvote_qos_all(struct ufs_hba *hba)

{

	struct ufs_qcom_host *host = ufshcd_get_variant(hba);

	struct ufs_qcom_qos_req *ufs_qos_req = host->ufs_qos;

	struct qos_cpu_group *qcg;

	int err, i;



	if (!host->ufs_qos)

		return 0;



	qcg = ufs_qos_req->qcg;

	for (i = 0; i < ufs_qos_req->num_groups; i++, qcg++) {

		flush_work(&qcg->vwork);

		if (!qcg->voted)

			continue;

		err = ufs_qcom_update_qos_constraints(qcg, QOS_MAX);

		if (err)

			dev_err(hba->dev, "Failed (%d) removing qos grp(%d)\n",

				err, i);

	}

	return err;

}



/**

/**

 * ufs_qcom_setup_clocks - enables/disable clocks

 * ufs_qcom_setup_clocks - enables/disable clocks

 * @hba: host controller instance

 * @hba: host controller instance
@@ -1723,6 +1792,9 @@ static int ufs_qcom_setup_clocks(struct ufs_hba *hba, bool on, 
				ufs_qcom_dev_ref_clk_ctrl(host, true);

				ufs_qcom_dev_ref_clk_ctrl(host, true);

		} else {

		} else {

			err = ufs_qcom_set_bus_vote(hba, false);

			err = ufs_qcom_set_bus_vote(hba, false);

			if (err)

				return err;

			err = ufs_qcom_unvote_qos_all(hba);

		}

		}

		if (!err)

		if (!err)

			atomic_set(&host->clks_on, on);

			atomic_set(&host->clks_on, on);
@@ -2121,6 +2193,208 @@ ufs_qcom_ioctl(struct scsi_device *dev, unsigned int cmd, void __user *buffer) 
	return err;

	return err;

}

}





static int tag_to_cpu(struct ufs_hba *hba, unsigned int tag)

{

	struct ufshcd_lrb *lrbp = &hba->lrb[tag];



	if (lrbp && lrbp->cmd && lrbp->cmd->request)

		return blk_mq_rq_cpu(lrbp->cmd->request);

	return -EINVAL;

}



static struct qos_cpu_group *cpu_to_group(struct ufs_qcom_qos_req *r,

					  unsigned int cpu)

{

	int i;

	struct qos_cpu_group *g = r->qcg;



	if (cpu > num_possible_cpus())

		return NULL;

	for (i = 0; i < r->num_groups; i++, g++) {

		if (cpumask_test_cpu(cpu, &g->mask))

			return &r->qcg[i];

	}

	return NULL;

}



static int ufs_qcom_update_qos_constraints(struct qos_cpu_group *qcg,

					   enum constraint type)

{

	unsigned int vote;

	int cpu, err;

	struct dev_pm_qos_request *qos_req = qcg->qos_req;



	if (type == QOS_MAX)

		vote = S32_MAX;

	else

		vote = qcg->votes[type];

	dev_dbg(qcg->host->hba->dev, "%s: qcg: 0x%08x | const: %d\n",

		__func__, qcg, type);

	if (qcg->curr_vote == vote)

		return 0;

	for_each_cpu(cpu, &qcg->mask) {

		err = dev_pm_qos_update_request(qos_req, vote);

		dev_dbg(qcg->host->hba->dev, "%s: vote: %d | cpu: %d | qos_req: 0x%08x\n",

			__func__, vote, cpu, qos_req);

		if (err < 0)

			return err;

		++qos_req;

	}

	if (type == QOS_MAX)

		qcg->voted = false;

	else

		qcg->voted = true;

	qcg->curr_vote = vote;

	return 0;

}



static void ufs_qcom_qos(struct ufs_hba *hba, int tag, bool is_scsi_cmd)

{

	struct ufs_qcom_host *host = ufshcd_get_variant(hba);

	struct qos_cpu_group *qcg;

	int cpu;



	if (!host->ufs_qos)

		return;

	cpu = tag_to_cpu(hba, tag);

	if (cpu < 0)

		return;

	qcg = cpu_to_group(host->ufs_qos, cpu);

	if (qcg->voted) {

		dev_dbg(qcg->host->hba->dev, "%s: qcg: 0x%08x | Mask: 0x%08x - Already voted - return\n",

			__func__, qcg, qcg->mask);

		return;

	}

	queue_work(host->ufs_qos->workq, &qcg->vwork);

	dev_dbg(hba->dev, "Queued QoS work- cpu: %d\n", cpu);

}



static void ufs_qcom_vote_work(struct work_struct *work)

{

	int err;

	struct qos_cpu_group *qcg = container_of(work, struct qos_cpu_group,

						 vwork);



	err = ufs_qcom_update_qos_constraints(qcg, QOS_PERF);

	if (err)

		dev_err(qcg->host->hba->dev, "%s: update qos - failed: %d\n",

			__func__, err);

}



static int ufs_qcom_setup_qos(struct ufs_hba *hba)

{

	struct ufs_qcom_host *host = ufshcd_get_variant(hba);

	struct device *dev = hba->dev;

	struct ufs_qcom_qos_req *qr = host->ufs_qos;

	struct qos_cpu_group *qcg = qr->qcg;

	int i, err;



	for (i = 0; i < qr->num_groups; i++, qcg++) {

		qcg->qos_req = kcalloc(cpumask_weight(&qcg->mask),

					sizeof(struct dev_pm_qos_request),

					GFP_KERNEL);

		if (!qcg->qos_req) {

			err = -ENOMEM;

			if (!i)

				return err;

			goto free_mem;

		}

		dev_dbg(dev, "%s: qcg: 0x%08x | mask: 0x%08x | mask-wt: %d | qos_req: 0x%08x\n",

			__func__, qcg, qcg->mask, cpumask_weight(&qcg->mask),

			qcg->qos_req);

		err = add_group_qos(qcg, S32_MAX);

		if (err < 0) {

			dev_err(dev, "Fail (%d) add qos-req: grp-%d\n",

				err, i);

			if (!i) {

				kfree(qcg->qos_req);

				return err;

			}

			goto free_mem;

		}

		INIT_WORK(&qcg->vwork, ufs_qcom_vote_work);

	}

	qr->workq = create_singlethread_workqueue("qc_ufs_qos_swq");

	if (qr->workq)

		return 0;

	err = -1;

free_mem:

	while (i--) {

		kfree(qcg->qos_req);

		qcg--;

	}

	return err;

}



static void ufs_qcom_qos_init(struct ufs_hba *hba)

{

	struct device *dev = hba->dev;

	struct device_node *np = dev->of_node;

	struct device_node *group_node;

	struct ufs_qcom_qos_req *qr;

	struct qos_cpu_group *qcg;

	int i, err, mask = 0;

	struct ufs_qcom_host *host = ufshcd_get_variant(hba);



	qr = kzalloc(sizeof(*qr), GFP_KERNEL);

	if (!qr)

		return;



	host->ufs_qos = qr;

	qr->num_groups = of_get_available_child_count(np);

	dev_dbg(hba->dev, "num-groups: %d\n", qr->num_groups);

	if (!qr->num_groups) {

		dev_err(dev, "QoS groups undefined\n");

		kfree(qr);

		host->ufs_qos = NULL;

		return;

	}

	qcg = kzalloc(sizeof(*qcg) * qr->num_groups, GFP_KERNEL);

	if (!qcg) {

		kfree(qr);

		host->ufs_qos = NULL;

		return;

	}

	qr->qcg = qcg;

	for_each_available_child_of_node(np, group_node) {

		of_property_read_u32(group_node, "mask", &mask);

		qcg->mask.bits[0] = mask;

		if (!cpumask_subset(&qcg->mask, cpu_possible_mask)) {

			dev_err(dev, "Invalid group mask\n");

			goto out_err;

		}



		err = of_property_count_u32_elems(group_node, "vote");

		if (err <= 0) {

			dev_err(dev, "1 vote is needed, bailing out: %d\n",

				err);

			goto out_err;

		}

		qcg->votes = kmalloc(sizeof(*qcg->votes) * err, GFP_KERNEL);

		if (!qcg->votes)

			goto out_err;

		for (i = 0; i < err; i++) {

			if (of_property_read_u32_index(group_node, "vote", i,

						       &qcg->votes[i]))

				goto out_vote_err;

		}

		dev_dbg(dev, "%s: qcg: 0x%08x\n", __func__, qcg);

		qcg->host = host;

		++qcg;

	}

	if (ufs_qcom_setup_qos(hba))

		goto out_vote_err;

	return;

out_vote_err:

	for (i = 0, qcg = qr->qcg; i < qr->num_groups; i++, qcg++)

		kfree(qcg->votes);

out_err:

	kfree(qr->qcg);

	kfree(qr);

	host->ufs_qos = NULL;

}





static void ufs_qcom_parse_pm_level(struct ufs_hba *hba)

static void ufs_qcom_parse_pm_level(struct ufs_hba *hba)

{

{

	struct device *dev = hba->dev;

	struct device *dev = hba->dev;
@@ -2340,6 +2614,7 @@ static int ufs_qcom_init(struct ufs_hba *hba) 




	ufs_qcom_save_host_ptr(hba);

	ufs_qcom_save_host_ptr(hba);





	ufs_qcom_qos_init(hba);

	goto out;

	goto out;





out_set_load_vccq_parent:

out_set_load_vccq_parent:
@@ -2959,6 +3234,7 @@ static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = { 
	.dbg_register_dump	= ufs_qcom_dump_dbg_regs,

	.dbg_register_dump	= ufs_qcom_dump_dbg_regs,

	.device_reset		= ufs_qcom_device_reset,

	.device_reset		= ufs_qcom_device_reset,

	.config_scaling_param = ufs_qcom_config_scaling_param,

	.config_scaling_param = ufs_qcom_config_scaling_param,

	.setup_xfer_req         = ufs_qcom_qos,

};

};





/**

/**
@@ -3140,8 +3416,14 @@ static int ufs_qcom_probe(struct platform_device *pdev) 
static int ufs_qcom_remove(struct platform_device *pdev)

static int ufs_qcom_remove(struct platform_device *pdev)

{

{

	struct ufs_hba *hba =  platform_get_drvdata(pdev);

	struct ufs_hba *hba =  platform_get_drvdata(pdev);

	struct ufs_qcom_host *host = ufshcd_get_variant(hba);

	struct ufs_qcom_qos_req *r = host->ufs_qos;

	struct qos_cpu_group *qcg = r->qcg;

	int i;





	pm_runtime_get_sync(&(pdev)->dev);

	pm_runtime_get_sync(&(pdev)->dev);

	for (i = 0; i < r->num_groups; i++, qcg++)

		remove_group_qos(qcg);

	ufshcd_remove(hba);

	ufshcd_remove(hba);

	return 0;

	return 0;

}

}

drivers/scsi/ufs/ufs-qcom.h

+25 −0
Original line number Original line Diff line number Diff line
@@ -8,6 +8,7 @@ 
#include <linux/reset-controller.h>

#include <linux/reset-controller.h>

#include <linux/reset.h>

#include <linux/reset.h>

#include <linux/phy/phy.h>

#include <linux/phy/phy.h>

#include <linux/pm_qos.h>

#include "ufshcd.h"

#include "ufshcd.h"

#ifdef CONFIG_SCSI_UFSHCD_QTI

#ifdef CONFIG_SCSI_UFSHCD_QTI

#include "unipro.h"

#include "unipro.h"
@@ -269,6 +270,29 @@ struct qcom_bus_scale_data { 
	const char *name;

	const char *name;

};

};





struct qos_cpu_group {

	cpumask_t mask;

	unsigned int *votes;

	struct dev_pm_qos_request *qos_req;

	bool voted;

	struct work_struct vwork;

	struct ufs_qcom_host *host;

	unsigned int curr_vote;

};



struct ufs_qcom_qos_req {

	struct qos_cpu_group *qcg;

	unsigned int num_groups;

	struct workqueue_struct *workq;

};



/* Check for QOS_POWER when added to DT */

enum constraint {

	QOS_PERF,

	QOS_POWER,

	QOS_MAX,

};



struct ufs_qcom_host {

struct ufs_qcom_host {

	/*

	/*

	 * Set this capability if host controller supports the QUniPro mode

	 * Set this capability if host controller supports the QUniPro mode
@@ -341,6 +365,7 @@ struct ufs_qcom_host { 
	/* FlashPVL entries */

	/* FlashPVL entries */

	atomic_t scale_up;

	atomic_t scale_up;

	atomic_t clks_on;

	atomic_t clks_on;

	struct ufs_qcom_qos_req *ufs_qos;

};

};





static inline u32

static inline u32