Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 550245b5 authored by Helmut Schaa's avatar Helmut Schaa Committed by John W. Linville
Browse files

rt2x00: Remove incorrect led blink 



rt2800 devices are not capable of configuring arbitrary LED on/off
periods. The LED_CFG register fields ON_PERIOD and OFF_PERIOD are only
used by the hw when the LED mode is set to "blink upon TX".

Hence, remove the blink callback. This will result in software emulation
for LED blinking.

Signed-off-by: default avatarHelmut Schaa <helmut.schaa@googlemail.com>
Acked-by: default avatarGertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 0f287b74

drivers/net/wireless/rt2x00/rt2800lib.c

+0 −16
Original line number Diff line number Diff line
@@ -897,28 +897,12 @@ static void rt2800_brightness_set(struct led_classdev *led_cdev, 
	}

}



static int rt2800_blink_set(struct led_classdev *led_cdev,

			    unsigned long *delay_on, unsigned long *delay_off)

{

	struct rt2x00_led *led =

	    container_of(led_cdev, struct rt2x00_led, led_dev);

	u32 reg;



	rt2800_register_read(led->rt2x00dev, LED_CFG, &reg);

	rt2x00_set_field32(&reg, LED_CFG_ON_PERIOD, *delay_on);

	rt2x00_set_field32(&reg, LED_CFG_OFF_PERIOD, *delay_off);

	rt2800_register_write(led->rt2x00dev, LED_CFG, reg);



	return 0;

}



static void rt2800_init_led(struct rt2x00_dev *rt2x00dev,

		     struct rt2x00_led *led, enum led_type type)

{

	led->rt2x00dev = rt2x00dev;

	led->type = type;

	led->led_dev.brightness_set = rt2800_brightness_set;

	led->led_dev.blink_set = rt2800_blink_set;

	led->flags = LED_INITIALIZED;

}

#endif /* CONFIG_RT2X00_LIB_LEDS */