Commit 5416912a authored Dec 03, 2012 by Aaron Lu Committed by Jeff Garzik Dec 03, 2012

libata: set dma_mode to 0xff in reset

ata_device->dma_mode's initial value is zero, which is not a valid dma
mode, but ata_dma_enabled will return true for this value. This patch
sets dma_mode to 0xff in reset function, so that ata_dma_enabled will
not return true for this case, or it will cause problem for pata_acpi.

The corrsponding bugzilla page is at:
https://bugzilla.kernel.org/show_bug.cgi?id=49151



Reported-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Tested-by: Szymon Janc <szymon@janc.net.pl>
Tested-by: Dutra Julio <dutra.julio@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Cc: <stable@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent f295be25

drivers/ata/libata-core.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2559,6 +2559,7 @@ int ata_bus_probe(struct ata_port *ap)
		* bus as we may be talking too fast.
		*/
		dev->pio_mode = XFER_PIO_0;
		dev->dma_mode = 0xff;

		/* If the controller has a pio mode setup function
		* then use it to set the chipset to rights. Don't

drivers/ata/libata-eh.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2657,6 +2657,7 @@ int ata_eh_reset(struct ata_link *link, int classify,
		* bus as we may be talking too fast.
		*/
		dev->pio_mode = XFER_PIO_0;
		dev->dma_mode = 0xff;

		/* If the controller has a pio mode setup function
		* then use it to set the chipset to rights. Don't