Commit 53fddb66 authored Jul 27, 2018 by Jia-Ju Bai Committed by Dmitry Torokhov Jul 27, 2018

Input: aiptek - replace GFP_ATOMIC with GFP_KERNEL in aiptek_probe()



aiptek_probe() is never called in atomic context. It calls
usb_alloc_coherent() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC
can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 7a082a24

drivers/input/tablet/aiptek.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1712,7 +1712,7 @@ aiptek_probe(struct usb_interface intf, const struct usb_device_id id)
		}

		aiptek->data = usb_alloc_coherent(usbdev, AIPTEK_PACKET_LENGTH,
		GFP_ATOMIC, &aiptek->data_dma);
		GFP_KERNEL, &aiptek->data_dma);
		if (!aiptek->data) {
		dev_warn(&intf->dev, "cannot allocate usb buffer\n");
		goto fail1;