Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53e9c1ab authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Greg Kroah-Hartman
Browse files

signal: Replace BUG_ON()s 



[ Upstream commit 7f8af7bac5380f2d95a63a6f19964e22437166e1 ]

These really can be handled gracefully without killing the machine.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Reviewed-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 267960de

kernel/signal.c

+7 −4
Original line number Diff line number Diff line
@@ -1821,10 +1821,11 @@ struct sigqueue *sigqueue_alloc(void) 


void sigqueue_free(struct sigqueue *q)

{

	unsigned long flags;

	spinlock_t *lock = &current->sighand->siglock;

	unsigned long flags;



	BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));

	if (WARN_ON_ONCE(!(q->flags & SIGQUEUE_PREALLOC)))

		return;

	/*

	 * We must hold ->siglock while testing q->list

	 * to serialize with collect_signal() or with
@@ -1852,7 +1853,10 @@ int send_sigqueue(struct sigqueue *q, struct pid *pid, enum pid_type type) 
	unsigned long flags;

	int ret, result;



	BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));

	if (WARN_ON_ONCE(!(q->flags & SIGQUEUE_PREALLOC)))

		return 0;

	if (WARN_ON_ONCE(q->info.si_code != SI_TIMER))

		return 0;



	ret = -1;

	rcu_read_lock();
@@ -1871,7 +1875,6 @@ int send_sigqueue(struct sigqueue *q, struct pid *pid, enum pid_type type) 
		 * If an SI_TIMER entry is already queue just increment

		 * the overrun count.

		 */

		BUG_ON(q->info.si_code != SI_TIMER);

		q->info.si_overrun++;

		result = TRACE_SIGNAL_ALREADY_PENDING;

		goto out;