Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53a23207 authored by Ernst Sjöstrand's avatar Ernst Sjöstrand Committed by Alex Deucher
Browse files

amdgpu/dc: Fix double unlock in amdgpu_dm_commit_planes 



Reported by smartch:
amdgpu_dm_commit_planes() error: double unlock 'spin_lock:&crtc->dev->event_lock'
amdgpu_dm_commit_planes() error: double unlock 'irqsave:flags'

The error path doesn't return so we only need a single unlock.

Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarErnst Sjöstrand <ernstp@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 423788c7

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+0 −1
Original line number Diff line number Diff line
@@ -3904,7 +3904,6 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state, 
			DRM_ERROR("%s: acrtc %d, already busy\n",

				  __func__,

				  acrtc_attach->crtc_id);

			spin_unlock_irqrestore(&crtc->dev->event_lock, flags);

			/* In commit tail framework this cannot happen */

			WARN_ON(1);

		}