Commit 52ddda8d authored Aug 18, 2023 by Ruan Jinjie Committed by Greg Kroah-Hartman Aug 30, 2023

net: bcmgenet: Fix return value check for fixed_phy_register()



[ Upstream commit 32bbe64a1386065ab2aef8ce8cae7c689d0add6e ]

The fixed_phy_register() function returns error pointers and never
returns NULL. Update the checks accordingly.

Fixes: b0ba512e ("net: bcmgenet: enable driver to work without a device tree")
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 189ad377

drivers/net/ethernet/broadcom/genet/bcmmii.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -565,7 +565,7 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv)
		};

		phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);
		if (!phydev \|\| IS_ERR(phydev)) {
		if (IS_ERR(phydev)) {
		dev_err(kdev, "failed to register fixed PHY device\n");
		return -ENODEV;
		}