Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52c4dfce authored by Madhumitha Prabakaran's avatar Madhumitha Prabakaran Committed by Greg Kroah-Hartman
Browse files

Staging: vc04_services: Cleanup in ctrl_set_bitrate() 



Remove unnecessary variable from the function and make a corresponding
change w.r.t the variable. In addition to that align the parameters in
the parentheses to maintain Linux kernel coding style

Issue suggested by Coccinelle.

Signed-off-by: default avatarMadhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 06e8c289

drivers/staging/vc04_services/bcm2835-camera/controls.c

+3 −6
Original line number Diff line number Diff line
@@ -607,18 +607,15 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev, 
			    struct v4l2_ctrl *ctrl,

			    const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)

{

	int ret;

	struct vchiq_mmal_port *encoder_out;



	dev->capture.encode_bitrate = ctrl->val;



	encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0];



	ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out,

					    mmal_ctrl->mmal_id,

					    &ctrl->val, sizeof(ctrl->val));

	ret = 0;

	return ret;

	return vchiq_mmal_port_parameter_set(dev->instance, encoder_out,

					     mmal_ctrl->mmal_id, &ctrl->val,

					     sizeof(ctrl->val));

}



static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev,